Dear TC members,
below you will find some more comments from a further review of my Sun
colleague Michael Stahl:
18.855 style:type
formatting of the list is wrong.
the following description is missing:
18.858 style:use-window-font-color
^^ spurious
18.859 style:vertical-align
^^^^^^^^ not formatted as value
^^^^^^^^^^^^^^^^^^ this should be: column-sep
^^^^^^^^^^^^^^^^^^^^^^^^^^ not formatted as element
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not formatted as element
18.859.1 style:vertical-pos
this should be labeled 18.860.
18.860 style:vertical-rel
maybe there should be a reference to style:vertical-pos, which explains
the possible values. right now, the two are on the same page.
18.862 style:width
the elements are not formatted as elements.
18.863 style:wrap
imho the "run-through" value's description should have a reference to the
style:run-through attribute.
18.867 style:writing-mode
the whole list is formatted all wrong
the following definition of the "page" value is missing:
18.1011 table:is-sub-table
A nested table that is not a specified to be a subtable
^^^ spurious
18.1109 text:animation-direction
nothing is said about possible values.
18.1111 text:animation-start-inside
^ missing apostrophe
18.1113 text:animation-stop-inside
why is this different from what is written in 18.1111:
further:
^ missing apostrophe
18.1114 table:automatic-find-labels
this should be text:automatic-find-labels
18.1119 text:c
the following text is missing:
18.1126 text:class-names
^^^^^^^^^ actually, this is only true if the attribute occurs on
text:p or text:h; if it occurs on text:span, then the styles are text styles
^ spurious comma
18.1127 text:column-name
well, we don't display the data from the column name. maybe better:
specifies the name of the column from which to display data.
18.1132 text:cond-style-name
broken reference:
18.1133 text:condition
^^^^^^^^^^^^^^ not formatted as element
^^^^^^^^^^^^^^^^^^^^ all not formatted as element
not formatted as value ^^^^
^^^^^^^^^^^^^^^^^^^^^^^ not formatted as element
18.1137 text:continue-numbering
i have a more substantial problem with this attribute. using it on
text:list is all well and good, but why is it applicable to
text:numbered-paragraph?
in ODF 1.2, text:numbered-paragraph has a mandatory attribute
text:list-id. all numbered-paragraphs with the same list-id belong to
the same list. it is necessary to use an attribute, because the
numbered-paragraphs of a list may be interspersed with other elements.
if a list represented as a text:list would be interspersed in this way,
we would have several text:list elements with continue-list attributes
and (maybe) continue-numbering.
but numbered-paragraphs have list-id, and thus continue-numbering is
completely redundant.
(note that i implemented numbered-paragraph import for OOo 3.1, and it
just ignores this attribute)
can we deprecate, or better, remove the text:continue-numbering
attribute on text:numbered-paragraph in ODF 1.2?
18.1143 text:date-adjust
^^^^^^^^^^^^^^^^ is not formatted as an attribute
Best regards, Oliver.
--
=======================================================================
Sun Microsystems GmbH Oliver-Rainer Wittmann
Nagelsweg 55 Software Engineer - OpenOffice.org/StarOffice
20097 Hamburg
Germany Fax: (+49 40) 23 646 955
http://www.sun.de mailto:oliver-rainer.wittmann@sun.com
-----------------------------------------------------------------------
Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering
=======================================================================
Oliver-Rainer Wittmann (od) - OpenOffice.org Writer
OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS