OASIS Virtual I/O Device (VIRTIO) TC

 View Only
Expand all | Collapse all

[PATCH] packed-ring: fix some typos

  • 1.  [PATCH] packed-ring: fix some typos

    Posted 03-24-2022 10:34
    flag is misnamed in a couple of places. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- packed-ring.tex 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packed-ring.tex b/packed-ring.tex index e41f8bf..2accc23 100644 --- a/packed-ring.tex +++ b/packed-ring.tex @@ -518,7 +518,7 @@ subsection{Event Suppression Structure Format}label{sec:Basic list. drivernormative{subsection}{Indirect Descriptors}{Basic Facilities of a Virtio Device / Packed Virtqueues / The Virtqueue Descriptor Table / Indirect Descriptors} -The driver MUST NOT set the DESC_F_INDIRECT flag unless the +The driver MUST NOT set the VIRTQ_DESC_F_INDIRECT flag unless the VIRTIO_F_INDIRECT_DESC feature was negotiated. The driver MUST NOT set any flags except DESC_F_WRITE within an indirect descriptor. @@ -526,7 +526,7 @@ subsection{Event Suppression Structure Format}label{sec:Basic by the device. A driver MUST NOT write direct descriptors with -DESC_F_INDIRECT set in a scatter-gather list linked by +VIRTQ_DESC_F_INDIRECT set in a scatter-gather list linked by VIRTQ_DESC_F_NEXT. field{flags}. -- MST


  • 2.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 03-24-2022 11:23
    On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:

    > flag is misnamed in a couple of places.

    s//The VIRTQ_DESC_F_INDIRECT_FLAG /

    >
    > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    > ---
    > packed-ring.tex | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)

    Reviewed-by: Cornelia Huck <cohuck@redhat.com>




  • 3.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 03-24-2022 11:23
    On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:

    > flag is misnamed in a couple of places.

    s//The VIRTQ_DESC_F_INDIRECT_FLAG /

    >
    > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    > ---
    > packed-ring.tex | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)

    Reviewed-by: Cornelia Huck <cohuck@redhat.com>




  • 4.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 03-24-2022 11:24
    On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote: > flag is misnamed in a couple of places. s//The VIRTQ_DESC_F_INDIRECT_FLAG / > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > packed-ring.tex 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck <cohuck@redhat.com>


  • 5.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 03-24-2022 12:03
    On Thu, Mar 24, 2022 at 12:23:23PM +0100, Cornelia Huck wrote:
    > On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:
    >
    > > flag is misnamed in a couple of places.
    >
    > s//The VIRTQ_DESC_F_INDIRECT_FLAG /

    You mean VIRTQ_DESC_F_INDIRECT don't you?

    > >
    > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    > > ---
    > > packed-ring.tex | 4 ++--
    > > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > Reviewed-by: Cornelia Huck <cohuck@redhat.com>




  • 6.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 03-24-2022 12:03
    On Thu, Mar 24, 2022 at 12:23:23PM +0100, Cornelia Huck wrote:
    > On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:
    >
    > > flag is misnamed in a couple of places.
    >
    > s//The VIRTQ_DESC_F_INDIRECT_FLAG /

    You mean VIRTQ_DESC_F_INDIRECT don't you?

    > >
    > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    > > ---
    > > packed-ring.tex | 4 ++--
    > > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > Reviewed-by: Cornelia Huck <cohuck@redhat.com>




  • 7.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 03-24-2022 12:03
    On Thu, Mar 24, 2022 at 12:23:23PM +0100, Cornelia Huck wrote: > On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > flag is misnamed in a couple of places. > > s//The VIRTQ_DESC_F_INDIRECT_FLAG / You mean VIRTQ_DESC_F_INDIRECT don't you? > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > --- > > packed-ring.tex 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Cornelia Huck <cohuck@redhat.com>


  • 8.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 03-24-2022 12:24
    On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:

    > On Thu, Mar 24, 2022 at 12:23:23PM +0100, Cornelia Huck wrote:
    >> On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:
    >>
    >> > flag is misnamed in a couple of places.
    >>
    >> s//The VIRTQ_DESC_F_INDIRECT_FLAG /
    >
    > You mean VIRTQ_DESC_F_INDIRECT don't you?

    Typo corrected by another typo... yeah.

    >
    >> >
    >> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    >> > ---
    >> > packed-ring.tex | 4 ++--
    >> > 1 file changed, 2 insertions(+), 2 deletions(-)
    >>
    >> Reviewed-by: Cornelia Huck <cohuck@redhat.com>




  • 9.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 03-24-2022 12:24
    On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:

    > On Thu, Mar 24, 2022 at 12:23:23PM +0100, Cornelia Huck wrote:
    >> On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:
    >>
    >> > flag is misnamed in a couple of places.
    >>
    >> s//The VIRTQ_DESC_F_INDIRECT_FLAG /
    >
    > You mean VIRTQ_DESC_F_INDIRECT don't you?

    Typo corrected by another typo... yeah.

    >
    >> >
    >> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    >> > ---
    >> > packed-ring.tex | 4 ++--
    >> > 1 file changed, 2 insertions(+), 2 deletions(-)
    >>
    >> Reviewed-by: Cornelia Huck <cohuck@redhat.com>




  • 10.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 03-24-2022 12:24
    On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Thu, Mar 24, 2022 at 12:23:23PM +0100, Cornelia Huck wrote: >> On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote: >> >> > flag is misnamed in a couple of places. >> >> s//The VIRTQ_DESC_F_INDIRECT_FLAG / > > You mean VIRTQ_DESC_F_INDIRECT don't you? Typo corrected by another typo... yeah. > >> > >> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> >> > --- >> > packed-ring.tex 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Reviewed-by: Cornelia Huck <cohuck@redhat.com>


  • 11.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 04-20-2022 09:46
    On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:

    > flag is misnamed in a couple of places.
    >
    > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    > ---
    > packed-ring.tex | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)

    Thanks, applied as editorial update.




  • 12.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 04-20-2022 09:46
    On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:

    > flag is misnamed in a couple of places.
    >
    > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    > ---
    > packed-ring.tex | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)

    Thanks, applied as editorial update.




  • 13.  Re: [virtio-dev] [PATCH] packed-ring: fix some typos

    Posted 04-20-2022 09:46
    On Thu, Mar 24 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote: > flag is misnamed in a couple of places. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > packed-ring.tex 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, applied as editorial update.