OASIS Virtual I/O Device (VIRTIO) TC

 View Only

  • 1.  [PATCH] net: relax buf size requirements for mrg buffers

    Posted 03-27-2017 23:09
    VIRTIO-84 added a requirement that each buffer is > header size but there's no reason to require that for merge-able buffers since data can be placed in follow-up buffers. The current wording seems confusing enough that it seems likely no one relies on this. VIRTIO-159 Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- content.tex 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content.tex b/content.tex index e57ebc5..a67610f 100644 --- a/content.tex +++ b/content.tex @@ -3524,7 +3524,7 @@ making for 65562 or 1526 bytes. with buffers of at least 1526 bytes. end{itemize} item If VIRTIO_NET_F_MRG_RXBUF is negotiated, each buffer MUST be at - greater than the size of the struct virtio_net_hdr. +least the size of the struct virtio_net_hdr. end{itemize} egin{note} -- MST


  • 2.  Re: [virtio-dev] [PATCH] net: relax buf size requirements for mrg buffers

    Posted 03-28-2017 09:51
    On Tue, Mar 28, 2017 at 02:09:08AM +0300, Michael S. Tsirkin wrote:
    > VIRTIO-84 added a requirement that each buffer is > header size but
    > there's no reason to require that for merge-able buffers since data can
    > be placed in follow-up buffers.
    >
    > The current wording seems confusing enough that it seems likely
    > no one relies on this.
    >
    > VIRTIO-159
    >
    > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    > ---
    > content.tex | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)

    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>



  • 3.  Re: [virtio-dev] [PATCH] net: relax buf size requirements for mrg buffers

    Posted 03-28-2017 09:51
    On Tue, Mar 28, 2017 at 02:09:08AM +0300, Michael S. Tsirkin wrote: > VIRTIO-84 added a requirement that each buffer is > header size but > there's no reason to require that for merge-able buffers since data can > be placed in follow-up buffers. > > The current wording seems confusing enough that it seems likely > no one relies on this. > > VIRTIO-159 > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > content.tex 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Attachment: signature.asc Description: PGP signature


  • 4.  Re: [virtio-dev] [PATCH] net: relax buf size requirements for mrg buffers

    Posted 03-29-2017 13:03


    On 03/28/2017 01:09 AM, Michael S. Tsirkin wrote:
    > VIRTIO-84 added a requirement that each buffer is > header size but
    > there's no reason to require that for merge-able buffers since data can
    > be placed in follow-up buffers.
    >
    > The current wording seems confusing enough that it seems likely
    > no one relies on this.
    >
    > VIRTIO-159
    >
    > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    > ---
    > content.tex | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)

    Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

    Thanks,
    Maxime



Related Content