OASIS Virtual I/O Device (VIRTIO) TC

 View Only
  • 1.  [PATCH] virtio-rng: fix device/driver confusion

    Posted 11-24-2019 12:44
    The point of rng is to give data to driver so of course all buffers are driver readable. What shouldn't be there is device readable buffers - this matches our terminology elsewhere too (read/write-ability is from POV of device). Fixes: https://github.com/oasis-tcs/virtio-spec/issues/55 Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- content.tex 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content.tex b/content.tex index 678afbe..72e832e 100644 --- a/content.tex +++ b/content.tex @@ -4721,7 +4721,7 @@ subsection{Device Operation}label{sec:Device Types / Entropy Device / Device O drivernormative{subsubsection}{Device Operation}{Device Types / Entropy Device / Device Operation} -The driver MUST NOT place driver-readable buffers into the queue. +The driver MUST NOT place device-readable buffers into the queue. The driver MUST examine the length written by the device to determine how many random bytes were received. -- MST


  • 2.  Re: [virtio-dev] [PATCH] virtio-rng: fix device/driver confusion

    Posted 11-25-2019 07:37

    >
    > The point of rng is to give data to driver so of course
    > all buffers are driver readable. What shouldn't be there
    > is device readable buffers - this matches our terminology
    > elsewhere too (read/write-ability is from POV of device).
    >
    > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/55
    > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

    Reviewed-by: Pankaj Gupta <pagupta@redhat.com>

    > ---
    > content.tex | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/content.tex b/content.tex
    > index 678afbe..72e832e 100644
    > --- a/content.tex
    > +++ b/content.tex
    > @@ -4721,7 +4721,7 @@ \subsection{Device Operation}\label{sec:Device Types /
    > Entropy Device / Device O
    >
    > \drivernormative{\subsubsection}{Device Operation}{Device Types / Entropy
    > Device / Device Operation}
    >
    > -The driver MUST NOT place driver-readable buffers into the queue.
    > +The driver MUST NOT place device-readable buffers into the queue.
    >
    > The driver MUST examine the length written by the device to determine
    > how many random bytes were received.
    > --
    > MST
    >
    >
    > ---------------------------------------------------------------------
    > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
    > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
    >
    >