OASIS Virtual I/O Device (VIRTIO) TC

The order of the fields in the legacy PCI header seems to get messed up in the new spec, with the "Queue Address" moved behind "Queue Notify". According to the 0.9.5 version of the spec it should be: * Device Features 32 * Driver Features 32 * Queue Address 32 * Queue Size 16 * Queue Select 16 * Queue Notify 16 * Device Status 8 * ISR Status 8 Signed-off-by: Pawel Moll <pawel.moll@arm.com> --- Reported by a colleague implementing a PCI device - it's got to be a copy-and-paste error. The Linux kernel driver definitely agrees with the 0.9.5 layout... content.tex 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content.tex b/content.tex index 5b11477..b1db063 100644 --- a/content.tex +++ b/content.tex @@ -959,7 +959,7 @@ When used through the legacy interface, the virtio header looks as follows: Read / Write & R & R+W & R+W & R & R+W & R+W & R+W & R \ hline Purpose & Device Features bits 0:31 & Driver Features bits 0:31 & - Queue Size & Queue Select & Queue Notify & Queue Address & + Queue Address & Queue Size & Queue Select & Queue Notify & Device Status & ISR
ewline Status \ hline end{tabularx} -- 1.8.3.2

Pawel Moll <pawel.moll@arm.com> writes: > The order of the fields in the legacy PCI header seems to get > messed up in the new spec, with the "Queue Address" moved > behind "Queue Notify". According to the 0.9.5 version of the spec > it should be: > > * Device Features 32 > * Driver Features 32 > * Queue Address 32 > * Queue Size 16 > * Queue Select 16 > * Queue Notify 16 > * Device Status 8 > * ISR Status 8 Yes, you can see the mistaken transform in 4601066a. IMHO this qualifies as a minor fix, please apply. Thanks, Rusty. > Reported by a colleague implementing a PCI device - it's got to > be a copy-and-paste error. The Linux kernel driver definitely > agrees with the 0.9.5 layout... Please apologize, and thank them! Cheers, Rusty.