virtio-comment

 View Only

  • 1.  [PATCH] virtio: fix feature bit thinko

    Posted 08-26-2013 19:47
    32 Feature bits means 0 to 31, not 32.

    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    ---

    Should I be able to commit this directly?
    Not sure how.

    virtio-v1.0-wd01-part1-specification.txt | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/virtio-v1.0-wd01-part1-specification.txt b/virtio-v1.0-wd01-part1-specification.txt
    index a3ee054..3c4260a 100644
    --- a/virtio-v1.0-wd01-part1-specification.txt
    +++ b/virtio-v1.0-wd01-part1-specification.txt
    @@ -134,7 +134,7 @@ Feature bits are allocated as follows:

    0 to 23: Feature bits for the specific device type

    - 24 to 32: Feature bits reserved for extensions to the queue and
    + 24 to 31: Feature bits reserved for extensions to the queue and
    feature negotiation mechanisms

    For example, feature bit 0 for a network device (i.e. Subsystem
    --
    MST



  • 2.  Re: [virtio-comment] [PATCH] virtio: fix feature bit thinko

    Posted 08-27-2013 06:16
    "Michael S. Tsirkin" <mst@redhat.com> writes:
    > 32 Feature bits means 0 to 31, not 32.
    >
    > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    > ---
    >
    > Should I be able to commit this directly?
    > Not sure how.

    You should, but let's discuss at the meeting. If not, I can certainly
    apply it.

    Thanks,
    Rusty.




Related Content