virtio-comment

 View Only

[PATCH] virtio-gpio: offered -> negotiated

  • 1.  [PATCH] virtio-gpio: offered -> negotiated

    Posted 01-25-2022 12:25
    virtqueues are only discovered after FEATURES_OK.
    As such it makes no sense to talk about virtqueues being affected by
    features which are offered but not negotiated, and doing so will confuse
    the reader.

    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    ---

    Viresh, others your thoughts on this? Looks like an obvious typo
    to me, and something that I think we can fix under the editorial
    changes rule.

    virtio-gpio.tex | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/virtio-gpio.tex b/virtio-gpio.tex
    index 55c553f..8e5c7f0 100644
    --- a/virtio-gpio.tex
    +++ b/virtio-gpio.tex
    @@ -15,7 +15,7 @@ \subsection{Virtqueues}\label{sec:Device Types / GPIO Device / Virtqueues}
    \end{description}

    The \field{eventq} virtqueue is available only if the \field{VIRTIO_GPIO_F_IRQ}
    -feature is offered by the device.
    +feature has been negotiated.

    \subsection{Feature bits}\label{sec:Device Types / GPIO Device / Feature bits}

    --
    MST