virtio-comment

 View Only
Back to discussions
Expand all | Collapse all

[felipe@nutanix.com: [PATCH] content: Fix driver/device wording on ISR bits]

  • 1.  [felipe@nutanix.com: [PATCH] content: Fix driver/device wording on ISR bits]

    Posted 11-20-2020 15:02
    Some kind of technical problem seems to prevent this patch from
    getting to list. Forwarding.

    ----- Forwarded message from Felipe Franciosi <felipe@nutanix.com> -----

    Date: Mon, 09 Nov 2020 14:13:18 +0000 (UTC)
    From: Felipe Franciosi <felipe@nutanix.com>
    To: virtio-comment@lists.oasis-open.org
    Cc: mst@redhat.com, Felipe Franciosi <felipe@nutanix.com>
    Subject: [PATCH] content: Fix driver/device wording on ISR bits
    Message-Id: <20201109141256.152571-1-felipe@nutanix.com>

    Section "ISR status capability" incorrectly worded that the bits part of
    the register allows the device to distinguish between interrupt types.
    It is the driver that needs access to that distinction, not the device.

    Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
    ---
    content.tex | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/content.tex b/content.tex
    index bc26674..3e8effe 100644
    --- a/content.tex
    +++ b/content.tex
    @@ -1040,7 +1040,7 @@ \subsubsection{ISR status capability}\label{sec:Virtio Transport Options / Virti

    The \field{offset} for the \field{ISR status} has no alignment requirements.

    -The ISR bits allow the device to distinguish between device-specific configuration
    +The ISR bits allow the driver to distinguish between device-specific configuration
    change interrupts and normal virtqueue interrupts:

    \begin{tabular}{ |l||l|l|l| }
    --
    2.18.4

    ----- End forwarded message -----




  • 2.  Re: [felipe@nutanix.com: [PATCH] content: Fix driver/device wording on ISR bits]

    Posted 11-23-2020 15:40
    On Fri, 20 Nov 2020 10:01:41 -0500
    "Michael S. Tsirkin" <mst@redhat.com> wrote:

    > Some kind of technical problem seems to prevent this patch from
    > getting to list. Forwarding.
    >
    > ----- Forwarded message from Felipe Franciosi <felipe@nutanix.com> -----
    >
    > Date: Mon, 09 Nov 2020 14:13:18 +0000 (UTC)
    > From: Felipe Franciosi <felipe@nutanix.com>
    > To: virtio-comment@lists.oasis-open.org
    > Cc: mst@redhat.com, Felipe Franciosi <felipe@nutanix.com>
    > Subject: [PATCH] content: Fix driver/device wording on ISR bits
    > Message-Id: <20201109141256.152571-1-felipe@nutanix.com>
    >
    > Section "ISR status capability" incorrectly worded that the bits part of
    > the register allows the device to distinguish between interrupt types.
    > It is the driver that needs access to that distinction, not the device.
    >
    > Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
    > ---
    > content.tex | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/content.tex b/content.tex
    > index bc26674..3e8effe 100644
    > --- a/content.tex
    > +++ b/content.tex
    > @@ -1040,7 +1040,7 @@ \subsubsection{ISR status capability}\label{sec:Virtio Transport Options / Virti
    >
    > The \field{offset} for the \field{ISR status} has no alignment requirements.
    >
    > -The ISR bits allow the device to distinguish between device-specific configuration
    > +The ISR bits allow the driver to distinguish between device-specific configuration
    > change interrupts and normal virtqueue interrupts:
    >
    > \begin{tabular}{ |l||l|l|l| }

    Reviewed-by: Cornelia Huck <cohuck@redhat.com>




Related Content