On Fri, Mar 24, 2023 at 04:35:34AM +0300, Parav Pandit wrote:
> queue_msix_vector register is for receiving interrupts from the device
> for the virtqueue.
>
> "for MSI-X" is confusing term.
>
> Also it is the register that driver "writes" to, similar to
> many other registers such as queue_desc, queue_driver etc.
>
> Hence, replace the verb from use to write.
>
> Signed-off-by: Parav Pandit <
parav@nvidia.com>
> Reviewed-by: Max Gurtovoy <
mgurtovoy@nvidia.com>
> ---
> transport-pci.tex | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/transport-pci.tex b/transport-pci.tex
> index 1bc89b4..9d492d5 100644
> --- a/transport-pci.tex
> +++ b/transport-pci.tex
> @@ -367,7 +367,8 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
> A 0 means the queue is unavailable.
>
> \item[\field{queue_msix_vector}]
> - The driver uses this to specify the queue vector for MSI-X.
> + The driver writes an MSI-X vector number for receiving
> + virtqueue interrupts.
Ok but "receiving" is confusing here. And the verb writes seems
to ask for direction, look at queue_desc as an example.
Following that example:
The driver writes the MSI-X vector number used for virtqueue interrupts here.
would you agree?
> \item[\field{queue_enable}]
> The driver uses this to selectively prevent the device from executing requests from this virtqueue.
> --
> 2.26.2