virtio-comment

Add the missing references to the virtqueue reset related conformance
requirements.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/181
Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
---
changelog:
- This patch is being resend as independent patch
- same patch as before at https://lists.oasis-open.org/archives/virtio-comment/202310/msg00184.html
---
conformance.tex | 2 ++
1 file changed, 2 insertions(+)

diff --git a/conformance.tex b/conformance.tex
index dc00e84..863f9c5 100644
--- a/conformance.tex
+++ b/conformance.tex
@@ -76,6 +76,7 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets}
\item \ref{drivernormative:Basic Facilities of a Virtio Device / Device Reset}
\item \ref{drivernormative:Basic Facilities of a Virtio Device / Device Configuration Space}
\item \ref{drivernormative:Basic Facilities of a Virtio Device / Virtqueues}
+\item \ref{drivernormative:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset / Virtqueue Reset}
\item \ref{drivernormative:Basic Facilities of a Virtio Device / Message Framing}
\item \ref{drivernormative:Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table}
\item \ref{drivernormative:Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table / Indirect Descriptors}
@@ -162,6 +163,7 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets}
\item \ref{devicenormative:Basic Facilities of a Virtio Device / Feature Bits}
\item \ref{devicenormative:Basic Facilities of a Virtio Device / Device Reset}
\item \ref{devicenormative:Basic Facilities of a Virtio Device / Device Configuration Space}
+\item \ref{devicenormative:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset / Virtqueue Reset}
\item \ref{devicenormative:Basic Facilities of a Virtio Device / Message Framing}
\item \ref{devicenormative:Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table}
\item \ref{devicenormative:Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table / Indirect Descriptors}
--
2.34.1

Hi Cornelia,

> From: Parav Pandit <parav@nvidia.com>
> Sent: Friday, October 27, 2023 7:03 PM
>
> Add the missing references to the virtqueue reset related conformance
> requirements.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/181
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> ---
> changelog:
> - This patch is being resend as independent patch
> - same patch as before at https://lists.oasis-open.org/archives/virtio-
> comment/202310/msg00184.html
> ---
> conformance.tex | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/conformance.tex b/conformance.tex index dc00e84..863f9c5 100644
> --- a/conformance.tex
> +++ b/conformance.tex
> @@ -76,6 +76,7 @@ \section{Conformance Targets}\label{sec:Conformance /
> Conformance Targets} \item \ref{drivernormative:Basic Facilities of a Virtio
> Device / Device Reset} \item \ref{drivernormative:Basic Facilities of a Virtio
> Device / Device Configuration Space} \item \ref{drivernormative:Basic
> Facilities of a Virtio Device / Virtqueues}
> +\item \ref{drivernormative:Basic Facilities of a Virtio Device /
> +Virtqueues / Virtqueue Reset / Virtqueue Reset}
> \item \ref{drivernormative:Basic Facilities of a Virtio Device / Message
> Framing} \item \ref{drivernormative:Basic Facilities of a Virtio Device /
> Virtqueues / The Virtqueue Descriptor Table} \item \ref{drivernormative:Basic
> Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table /
> Indirect Descriptors} @@ -162,6 +163,7 @@ \section{Conformance
> Targets}\label{sec:Conformance / Conformance Targets} \item
> \ref{devicenormative:Basic Facilities of a Virtio Device / Feature Bits} \item
> \ref{devicenormative:Basic Facilities of a Virtio Device / Device Reset} \item
> \ref{devicenormative:Basic Facilities of a Virtio Device / Device Configuration
> Space}
> +\item \ref{devicenormative:Basic Facilities of a Virtio Device /
> +Virtqueues / Virtqueue Reset / Virtqueue Reset}
> \item \ref{devicenormative:Basic Facilities of a Virtio Device / Message
> Framing} \item \ref{devicenormative:Basic Facilities of a Virtio Device /
> Virtqueues / The Virtqueue Descriptor Table} \item \ref{devicenormative:Basic
> Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table /
> Indirect Descriptors}
> --
> 2.34.1

It is very old. It was part of dynamic vq creation series.
It is same old patch, already reviewed.

Can you please raise the voting for this fix?

On Fri, Oct 27, 2023 at 01:36:03PM +0000, Parav Pandit wrote:
> Hi Cornelia,
>
> > From: Parav Pandit <parav@nvidia.com>
> > Sent: Friday, October 27, 2023 7:03 PM
> >
> > Add the missing references to the virtqueue reset related conformance
> > requirements.
> >
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/181
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> > ---
> > changelog:
> > - This patch is being resend as independent patch
> > - same patch as before at https://lists.oasis-open.org/archives/virtio-
> > comment/202310/msg00184.html
> > ---
> > conformance.tex | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/conformance.tex b/conformance.tex index dc00e84..863f9c5 100644
> > --- a/conformance.tex
> > +++ b/conformance.tex
> > @@ -76,6 +76,7 @@ \section{Conformance Targets}\label{sec:Conformance /
> > Conformance Targets} \item \ref{drivernormative:Basic Facilities of a Virtio
> > Device / Device Reset} \item \ref{drivernormative:Basic Facilities of a Virtio
> > Device / Device Configuration Space} \item \ref{drivernormative:Basic
> > Facilities of a Virtio Device / Virtqueues}
> > +\item \ref{drivernormative:Basic Facilities of a Virtio Device /
> > +Virtqueues / Virtqueue Reset / Virtqueue Reset}
> > \item \ref{drivernormative:Basic Facilities of a Virtio Device / Message
> > Framing} \item \ref{drivernormative:Basic Facilities of a Virtio Device /
> > Virtqueues / The Virtqueue Descriptor Table} \item \ref{drivernormative:Basic
> > Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table /
> > Indirect Descriptors} @@ -162,6 +163,7 @@ \section{Conformance
> > Targets}\label{sec:Conformance / Conformance Targets} \item
> > \ref{devicenormative:Basic Facilities of a Virtio Device / Feature Bits} \item
> > \ref{devicenormative:Basic Facilities of a Virtio Device / Device Reset} \item
> > \ref{devicenormative:Basic Facilities of a Virtio Device / Device Configuration
> > Space}
> > +\item \ref{devicenormative:Basic Facilities of a Virtio Device /
> > +Virtqueues / Virtqueue Reset / Virtqueue Reset}
> > \item \ref{devicenormative:Basic Facilities of a Virtio Device / Message
> > Framing} \item \ref{devicenormative:Basic Facilities of a Virtio Device /
> > Virtqueues / The Virtqueue Descriptor Table} \item \ref{devicenormative:Basic
> > Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table /
> > Indirect Descriptors}
> > --
> > 2.34.1
>
> It is very old. It was part of dynamic vq creation series.
> It is same old patch, already reviewed.
>
> Can you please raise the voting for this fix?


I think we can merge it as editorial actually. Cornelia?

On Fri, Oct 27 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Fri, Oct 27, 2023 at 01:36:03PM +0000, Parav Pandit wrote:
>> Hi Cornelia,
>>
>> > From: Parav Pandit <parav@nvidia.com>
>> > Sent: Friday, October 27, 2023 7:03 PM
>> >
>> > Add the missing references to the virtqueue reset related conformance
>> > requirements.
>> >
>> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/181
>> > Signed-off-by: Parav Pandit <parav@nvidia.com>
>> > Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
>> > ---
>> > changelog:
>> > - This patch is being resend as independent patch
>> > - same patch as before at https://lists.oasis-open.org/archives/virtio-
>> > comment/202310/msg00184.html
>> > ---
>> > conformance.tex | 2 ++
>> > 1 file changed, 2 insertions(+)
>> >
>> > diff --git a/conformance.tex b/conformance.tex index dc00e84..863f9c5 100644
>> > --- a/conformance.tex
>> > +++ b/conformance.tex
>> > @@ -76,6 +76,7 @@ \section{Conformance Targets}\label{sec:Conformance /
>> > Conformance Targets} \item \ref{drivernormative:Basic Facilities of a Virtio
>> > Device / Device Reset} \item \ref{drivernormative:Basic Facilities of a Virtio
>> > Device / Device Configuration Space} \item \ref{drivernormative:Basic
>> > Facilities of a Virtio Device / Virtqueues}
>> > +\item \ref{drivernormative:Basic Facilities of a Virtio Device /
>> > +Virtqueues / Virtqueue Reset / Virtqueue Reset}
>> > \item \ref{drivernormative:Basic Facilities of a Virtio Device / Message
>> > Framing} \item \ref{drivernormative:Basic Facilities of a Virtio Device /
>> > Virtqueues / The Virtqueue Descriptor Table} \item \ref{drivernormative:Basic
>> > Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table /
>> > Indirect Descriptors} @@ -162,6 +163,7 @@ \section{Conformance
>> > Targets}\label{sec:Conformance / Conformance Targets} \item
>> > \ref{devicenormative:Basic Facilities of a Virtio Device / Feature Bits} \item
>> > \ref{devicenormative:Basic Facilities of a Virtio Device / Device Reset} \item
>> > \ref{devicenormative:Basic Facilities of a Virtio Device / Device Configuration
>> > Space}
>> > +\item \ref{devicenormative:Basic Facilities of a Virtio Device /
>> > +Virtqueues / Virtqueue Reset / Virtqueue Reset}
>> > \item \ref{devicenormative:Basic Facilities of a Virtio Device / Message
>> > Framing} \item \ref{devicenormative:Basic Facilities of a Virtio Device /
>> > Virtqueues / The Virtqueue Descriptor Table} \item \ref{devicenormative:Basic
>> > Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table /
>> > Indirect Descriptors}
>> > --
>> > 2.34.1
>>
>> It is very old. It was part of dynamic vq creation series.
>> It is same old patch, already reviewed.
>>
>> Can you please raise the voting for this fix?
>
>
> I think we can merge it as editorial actually. Cornelia?

I agree. (Someone should probably merge the voted issues on the 1.4
branch first.)

On Fri, Oct 27 2023, Cornelia Huck <cohuck@redhat.com> wrote:

> On Fri, Oct 27 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>> I think we can merge it as editorial actually. Cornelia?
>
> I agree. (Someone should probably merge the voted issues on the 1.4
> branch first.)

But what I'll do is removing the "Fixes:" line and close the github
issue manually. We should use github issues for voting only, not for
editorial changes (we need some way to distinguish between the two, and
I'd rather have a straightforward way to do so.)

On Mon, Oct 30, 2023 at 12:01:28PM +0100, Cornelia Huck wrote:
> On Fri, Oct 27 2023, Cornelia Huck <cohuck@redhat.com> wrote:
>
> > On Fri, Oct 27 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >> I think we can merge it as editorial actually. Cornelia?
> >
> > I agree. (Someone should probably merge the voted issues on the 1.4
> > branch first.)
>
> But what I'll do is removing the "Fixes:" line and close the github
> issue manually. We should use github issues for voting only, not for
> editorial changes (we need some way to distinguish between the two, and
> I'd rather have a straightforward way to do so.)

Agree totally, that seems like the best way to do it.
If this begins to happen a lot we can add an "editorial" tag though.

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Monday, October 30, 2023 4:42 PM
>
> On Mon, Oct 30, 2023 at 12:01:28PM +0100, Cornelia Huck wrote:
> > On Fri, Oct 27 2023, Cornelia Huck <cohuck@redhat.com> wrote:
> >
> > > On Fri, Oct 27 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > >> I think we can merge it as editorial actually. Cornelia?
> > >
> > > I agree. (Someone should probably merge the voted issues on the 1.4
> > > branch first.)
> >
> > But what I'll do is removing the "Fixes:" line and close the github
> > issue manually. We should use github issues for voting only, not for
> > editorial changes (we need some way to distinguish between the two,
> > and I'd rather have a straightforward way to do so.)
>
> Agree totally, that seems like the best way to do it.
> If this begins to happen a lot we can add an "editorial" tag though.

Thanks.