OASIS Static Analysis Results Interchange Format (SARIF) TC

Fixing duplicate threadId property

  • 1.  Fixing duplicate threadId property

    Posted 03-28-2018 21:41
    I noticed that we now have two threadId properties, as follows:   results: [   {                                         # A result object.     codeFlows: [       {                                     # A codeFlow object.         threadFlows: [           {                                 # A threadFlow object              threadId: "52",                  # Added in #80.             "locations": [               {                             # An annocatedCodeLocation object, soon to be renamed codeFlowLocation per #130.                  "threadId": "52"             # Should have been removed in #80, but was not.               }             ]           }        ]       }     ]   } ]   Recall that annotatedCodeLocation.threadId is the mechanism we used to use to distinguish multiple threads in a single codeFlow . But now we separate each thread into its own threadFlow object, so there’s no reason for each annotatedCodeLocation ( a.k.a. codeFlowLocation ) to have its own thread id.   So I’m going to use my editorial discretion to remove annotatedCodeLocation.threadId . I consider it a bug that I failed to do that in the change draft.   Thanks, Larry