Thanks for spotting those two errors. I just pushed the fixes to the change draft. Thanks also for reading so carefully! which you clearly did to spot those errors. I take it the rest of it meets with your approval (and I hope with Jim’s as well). I will read your Issue #178 and respond separately. Also, stay tuned for an important message about something the spec does not say, intentionally. Larry From:
sarif@lists.oasis-open.org <
sarif@lists.oasis-open.org> On Behalf Of Luke Cartey Sent: Thursday, May 24, 2018 7:53 AM To: Larry Golding (Comcast) <
larrygolding@comcast.net> Cc:
sarif@lists.oasis-open.org; Michael Fanning <
Michael.Fanning@microsoft.com>; James A. Kupsch <
kupsch@cs.wisc.edu> Subject: [sarif] Re: REVISED Change draft for #93 (region improvements) Hi Larry, I've spotted a couple of minor issues with the current change draft: * Section 3.22.2, Example 4, the charLength should be 14 throughout. * Section 3.22.7 "endColumn" property still defines endColumn as inclusive, not exclusive. On a similar topic to this change draft, I've just filed an issue related to our interpretation of columns/characters:
https://github.com/oasis-tcs/sarif-spec/issues/178 As I think our current interpretation is going to create burden for both consumers and producers. Cheers, Luke On Thu, May 24, 2018 at 12:04 AM Larry Golding (Comcast) <
larrygolding@comcast.net > wrote: I pushed a revised change draft for Issue #93 , “Problems with regions”: Documents/ChangeDrafts/Active/sarif-v2.0-issue-93-region-improvements.docx I will move its adoption at TC #18 on May 30 th . Please see the examples at the end of the issue to understand the new proposal. I suggest that you read Section 3.22, “Region object” in its entirety as if it were new . Reading with Simple Markup will help a lot. I basically rewrite the whole section on regions. Thanks, Larry