OASIS Virtual I/O Device (VIRTIO) TC

This is not a huge deal since it's a SHOULD anyway, so make the new requirement SHOULD too. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- device-types/net/description.tex 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/device-types/net/description.tex b/device-types/net/description.tex index aff5e08..d1d25fe 100644 --- a/device-types/net/description.tex +++ b/device-types/net/description.tex @@ -1792,7 +1792,11 @@ subsubsection{Control Virtqueue}label{sec:Device Types / Network Device / Devi The device MUST ignore field{reserved}. -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters. +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if +it was not able to change coalescing parameters. In this case, +the parameters SHOULD remain unchanged, for all VQs. + The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters. -- MST

? 2024/1/24 ??7:15, Michael S. Tsirkin ??:
> This is not a huge deal since it's a SHOULD anyway,
> so make the new requirement SHOULD too.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> device-types/net/description.tex | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> index aff5e08..d1d25fe 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
>
> The device MUST ignore \field{reserved}.
>
> -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.
> +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
> +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if
> +it was not able to change coalescing parameters. In this case,
> +the parameters SHOULD remain unchanged, for all VQs.

Can we use "virtqueues" instead of "VQs"? Because "VQs" has not been
used in the text.

With this,

Reviewed-by: Heng Qi <hengqi@linux.alibaba.com>

Thanks!

> +
>
> The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.
>

? 2024/1/24 ??7:15, Michael S. Tsirkin ??:
> This is not a huge deal since it's a SHOULD anyway,
> so make the new requirement SHOULD too.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> device-types/net/description.tex | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> index aff5e08..d1d25fe 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
>
> The device MUST ignore \field{reserved}.
>
> -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.
> +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
> +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if
> +it was not able to change coalescing parameters. In this case,
> +the parameters SHOULD remain unchanged, for all VQs.

Can we use "virtqueues" instead of "VQs"? Because "VQs" has not been
used in the text.

With this,

Reviewed-by: Heng Qi <hengqi@linux.alibaba.com>

Thanks!

> +
>
> The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.
>

å 2024/1/24 äå7:15, Michael S. Tsirkin åé: This is not a huge deal since it's a SHOULD anyway, so make the new requirement SHOULD too. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- device-types/net/description.tex 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/device-types/net/description.tex b/device-types/net/description.tex index aff5e08..d1d25fe 100644 --- a/device-types/net/description.tex +++ b/device-types/net/description.tex @@ -1792,7 +1792,11 @@ subsubsection{Control Virtqueue}label{sec:Device Types / Network Device / Devi The device MUST ignore field{reserved}. -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters. +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if +it was not able to change coalescing parameters. In this case, +the parameters SHOULD remain unchanged, for all VQs. Can we use "virtqueues" instead of "VQs"? Because "VQs" has not been used in the text. With this, Reviewed-by: Heng Qi <hengqi@linux.alibaba.com> Thanks! + The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

On Wed, Jan 24 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> This is not a huge deal since it's a SHOULD anyway,
> so make the new requirement SHOULD too.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> device-types/net/description.tex | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> index aff5e08..d1d25fe 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
>
> The device MUST ignore \field{reserved}.
>
> -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.
> +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
> +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if
> +it was not able to change coalescing parameters. In this case,

Hm, if we explicitly specify "coalescing parameters" here, should we add
it below as well? (We probably should keep the "the".)

> +the parameters SHOULD remain unchanged, for all VQs.
> +
>
> The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

On Wed, Jan 24 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> This is not a huge deal since it's a SHOULD anyway,
> so make the new requirement SHOULD too.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> device-types/net/description.tex | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> index aff5e08..d1d25fe 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
>
> The device MUST ignore \field{reserved}.
>
> -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.
> +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
> +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if
> +it was not able to change coalescing parameters. In this case,

Hm, if we explicitly specify "coalescing parameters" here, should we add
it below as well? (We probably should keep the "the".)

> +the parameters SHOULD remain unchanged, for all VQs.
> +
>
> The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

On Wed, Jan 24 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote: > This is not a huge deal since it's a SHOULD anyway, > so make the new requirement SHOULD too. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > device-types/net/description.tex 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/device-types/net/description.tex b/device-types/net/description.tex > index aff5e08..d1d25fe 100644 > --- a/device-types/net/description.tex > +++ b/device-types/net/description.tex > @@ -1792,7 +1792,11 @@ subsubsection{Control Virtqueue}label{sec:Device Types / Network Device / Devi > > The device MUST ignore field{reserved}. > > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters. > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if > +it was not able to change coalescing parameters. In this case, Hm, if we explicitly specify "coalescing parameters" here, should we add it below as well? (We probably should keep the "the".) > +the parameters SHOULD remain unchanged, for all VQs. > + > > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote:
> On Wed, Jan 24 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > This is not a huge deal since it's a SHOULD anyway,
> > so make the new requirement SHOULD too.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > device-types/net/description.tex | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> > index aff5e08..d1d25fe 100644
> > --- a/device-types/net/description.tex
> > +++ b/device-types/net/description.tex
> > @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
> >
> > The device MUST ignore \field{reserved}.
> >
> > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.
> > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
> > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if
> > +it was not able to change coalescing parameters. In this case,
>
> Hm, if we explicitly specify "coalescing parameters" here, should we add
> it below as well? (We probably should keep the "the".)

maybe "some of the" and in the next sentence "all of the".

so it's atomic: all or nothing.

> > +the parameters SHOULD remain unchanged, for all VQs.
> > +
> >
> > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote:
> On Wed, Jan 24 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > This is not a huge deal since it's a SHOULD anyway,
> > so make the new requirement SHOULD too.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > device-types/net/description.tex | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> > index aff5e08..d1d25fe 100644
> > --- a/device-types/net/description.tex
> > +++ b/device-types/net/description.tex
> > @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
> >
> > The device MUST ignore \field{reserved}.
> >
> > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.
> > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
> > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if
> > +it was not able to change coalescing parameters. In this case,
>
> Hm, if we explicitly specify "coalescing parameters" here, should we add
> it below as well? (We probably should keep the "the".)

maybe "some of the" and in the next sentence "all of the".

so it's atomic: all or nothing.

> > +the parameters SHOULD remain unchanged, for all VQs.
> > +
> >
> > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote: > On Wed, Jan 24 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > This is not a huge deal since it's a SHOULD anyway, > > so make the new requirement SHOULD too. > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > --- > > device-types/net/description.tex 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/device-types/net/description.tex b/device-types/net/description.tex > > index aff5e08..d1d25fe 100644 > > --- a/device-types/net/description.tex > > +++ b/device-types/net/description.tex > > @@ -1792,7 +1792,11 @@ subsubsection{Control Virtqueue}label{sec:Device Types / Network Device / Devi > > > > The device MUST ignore field{reserved}. > > > > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters. > > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and > > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if > > +it was not able to change coalescing parameters. In this case, > > Hm, if we explicitly specify "coalescing parameters" here, should we add > it below as well? (We probably should keep the "the".) maybe "some of the" and in the next sentence "all of the". so it's atomic: all or nothing. > > +the parameters SHOULD remain unchanged, for all VQs. > > + > > > > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

On Mon, Jan 29 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote:
>> On Wed, Jan 24 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>>
>> > This is not a huge deal since it's a SHOULD anyway,
>> > so make the new requirement SHOULD too.
>> >
>> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> > ---
>> > device-types/net/description.tex | 6 +++++-
>> > 1 file changed, 5 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/device-types/net/description.tex b/device-types/net/description.tex
>> > index aff5e08..d1d25fe 100644
>> > --- a/device-types/net/description.tex
>> > +++ b/device-types/net/description.tex
>> > @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
>> >
>> > The device MUST ignore \field{reserved}.
>> >
>> > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.
>> > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
>> > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if
>> > +it was not able to change coalescing parameters. In this case,
>>
>> Hm, if we explicitly specify "coalescing parameters" here, should we add
>> it below as well? (We probably should keep the "the".)
>
> maybe "some of the" and in the next sentence "all of the".
>
> so it's atomic: all or nothing.

Makes sense.

>
>> > +the parameters SHOULD remain unchanged, for all VQs.
>> > +
>> >
>> > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

Also here ^ ?

On Mon, Jan 29 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote:
>> On Wed, Jan 24 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>>
>> > This is not a huge deal since it's a SHOULD anyway,
>> > so make the new requirement SHOULD too.
>> >
>> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> > ---
>> > device-types/net/description.tex | 6 +++++-
>> > 1 file changed, 5 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/device-types/net/description.tex b/device-types/net/description.tex
>> > index aff5e08..d1d25fe 100644
>> > --- a/device-types/net/description.tex
>> > +++ b/device-types/net/description.tex
>> > @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
>> >
>> > The device MUST ignore \field{reserved}.
>> >
>> > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.
>> > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
>> > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if
>> > +it was not able to change coalescing parameters. In this case,
>>
>> Hm, if we explicitly specify "coalescing parameters" here, should we add
>> it below as well? (We probably should keep the "the".)
>
> maybe "some of the" and in the next sentence "all of the".
>
> so it's atomic: all or nothing.

Makes sense.

>
>> > +the parameters SHOULD remain unchanged, for all VQs.
>> > +
>> >
>> > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

Also here ^ ?

On Mon, Jan 29 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote: >> On Wed, Jan 24 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote: >> >> > This is not a huge deal since it's a SHOULD anyway, >> > so make the new requirement SHOULD too. >> > >> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> >> > --- >> > device-types/net/description.tex 6 +++++- >> > 1 file changed, 5 insertions(+), 1 deletion(-) >> > >> > diff --git a/device-types/net/description.tex b/device-types/net/description.tex >> > index aff5e08..d1d25fe 100644 >> > --- a/device-types/net/description.tex >> > +++ b/device-types/net/description.tex >> > @@ -1792,7 +1792,11 @@ subsubsection{Control Virtqueue}label{sec:Device Types / Network Device / Devi >> > >> > The device MUST ignore field{reserved}. >> > >> > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters. >> > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and >> > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if >> > +it was not able to change coalescing parameters. In this case, >> >> Hm, if we explicitly specify "coalescing parameters" here, should we add >> it below as well? (We probably should keep the "the".) > > maybe "some of the" and in the next sentence "all of the". > > so it's atomic: all or nothing. Makes sense. > >> > +the parameters SHOULD remain unchanged, for all VQs. >> > + >> > >> > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters. Also here ^ ?