(Sent 7th July but not delivered)
Hi,
David Lindemann has been emailing me a few things about the DMLex converter and so I did some more testing and found at least one critical bug and a few other minor issues, so I am making a comment here. Hopefully this can be fixed without another community draft:
- XSD schema rejects entries, sense or collocateMarkers without @id. This attribute is marked as optional in the specification but is not in the XSD. Even more confusingly it only fails if the root element is lexicographicResource not when the element is entry. This means that examples A.1.21-23 pass the validation, but will fail if they are used within a lexicographicResource.
- Section 5.1 does not list <transcriptionSchemeTag> as a child of <lexicographicResource>
- Section 5.1 does not list which of the <text> tags can take <headwordMarker>, <collocateMarker> and <placeholderMarker>
There are also a few model issues I noticed. None of these are breaking so they could be pushed for a future update of the model
- Example translations can be headword markers, but they are translations so cannot actually contain the headword. Perhaps the intention is to indicate which word is the translation as follows:
<example>
<text>The <headwordMarker>cat</headwordMarker> sits on the <collocateMarker>mat</collocateMarker>.</text>
<exampleTranslation langCode="es">
<text>El <headwordMarker>gato</headwordMarker> se sienta en la <collocateMarker>alfombra</collocateMarker>.</text>
</exampleTranslation>
</example>
Still it seems a bit difficult and unnecessary, when exampleTranslation could be a plain string.
- Etymon has a translation, but this could be removed as each etymonUnit has a translation. I guess that this is just a shorthand for a translation that applies to all etymonUnits, so it is fine to leave it
- The etymology module should extend `sameAs` to apply to its two controlled value elements (`etymonLanguage` and `etymonType`)
Regards,
John
--
John P. McCrae
(he/him; #startsWithAName John (rhymes with "gone") McCrae (rhymes with "hay") /dʒɒn mækɹeɪ/)
Assistant Professor - SFI Insight Centre for Data Analytics, Data Science Institute & Computer Science, University of Galway
------------------------------
John McCrae
National University of Ireland Galway
Galway
35391495008
------------------------------